Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CM API IDL to use SecureContext #5755

Merged
merged 1 commit into from May 2, 2017

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 2, 2017

This change implements recent changes to the Credential Manager API
specification that introduce the |SecureContext| extended attribute on
its interfaces. Furthermore it removes
|RuntimeEnabled=CredentialManager| from the interfaces following the
discussion in http://crrev.com/2832813002.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/-E-O9LgsPfM/ExJ7hiY1BQAJ

BUG=715077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2844453002
Cr-Commit-Position: refs/heads/master@{#468596}


This change is Reviewable

This change implements recent changes to the Credential Manager API
specification that introduce the |SecureContext| extended attribute on
its interfaces. Furthermore it removes
|RuntimeEnabled=CredentialManager| from the interfaces following the
discussion in http://crrev.com/2832813002.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/-E-O9LgsPfM/ExJ7hiY1BQAJ

BUG=715077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2844453002
Cr-Commit-Position: refs/heads/master@{#468596}
@w3c-bots
Copy link

w3c-bots commented May 2, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision df14160
Using browser at version BuildID 20170501100238; SourceStamp 076a7a66096f9e8d102548397254be32eb26bc3d
Starting 10 test iterations
All results were stable

All results

1 test ran
/credential-management/idl.https.html
Subtest Results Messages
OK
CredentialsContainer interface: existence and properties of interface object FAIL assert_own_property: self does not have own property "CredentialsContainer" expected property "CredentialsContainer" missing
CredentialsContainer interface object length FAIL assert_own_property: self does not have own property "CredentialsContainer" expected property "CredentialsContainer" missing
CredentialsContainer interface object name FAIL assert_own_property: self does not have own property "CredentialsContainer" expected property "CredentialsContainer" missing
CredentialsContainer interface: existence and properties of interface prototype object FAIL assert_own_property: self does not have own property "CredentialsContainer" expected property "CredentialsContainer" missing
CredentialsContainer interface: existence and properties of interface prototype object's "constructor" property FAIL assert_own_property: self does not have own property "CredentialsContainer" expected property "CredentialsContainer" missing
CredentialsContainer interface: operation get(CredentialRequestOptions) FAIL assert_own_property: self does not have own property "CredentialsContainer" expected property "CredentialsContainer" missing
CredentialsContainer interface: operation store(Credential) FAIL assert_own_property: self does not have own property "CredentialsContainer" expected property "CredentialsContainer" missing
CredentialsContainer interface: operation requireUserMediation() FAIL assert_own_property: self does not have own property "CredentialsContainer" expected property "CredentialsContainer" missing
CredentialsContainer must be primary interface of navigator.credentials FAIL assert_equals: wrong typeof object expected "object" but got "undefined"
Stringification of navigator.credentials FAIL assert_equals: wrong typeof object expected "object" but got "undefined"
CredentialsContainer interface: navigator.credentials must inherit property "get" with the proper type (0) FAIL assert_equals: wrong typeof object expected "object" but got "undefined"
CredentialsContainer interface: calling get(CredentialRequestOptions) on navigator.credentials with too few arguments must throw TypeError FAIL assert_equals: wrong typeof object expected "object" but got "undefined"
CredentialsContainer interface: navigator.credentials must inherit property "store" with the proper type (1) FAIL assert_equals: wrong typeof object expected "object" but got "undefined"
CredentialsContainer interface: calling store(Credential) on navigator.credentials with too few arguments must throw TypeError FAIL assert_equals: wrong typeof object expected "object" but got "undefined"
CredentialsContainer interface: navigator.credentials must inherit property "requireUserMediation" with the proper type (2) FAIL assert_equals: wrong typeof object expected "object" but got "undefined"
PasswordCredential interface: existence and properties of interface object FAIL assert_own_property: self does not have own property "PasswordCredential" expected property "PasswordCredential" missing
PasswordCredential interface object length FAIL assert_own_property: self does not have own property "PasswordCredential" expected property "PasswordCredential" missing
PasswordCredential interface object name FAIL assert_own_property: self does not have own property "PasswordCredential" expected property "PasswordCredential" missing
PasswordCredential interface: existence and properties of interface prototype object FAIL assert_own_property: self does not have own property "PasswordCredential" expected property "PasswordCredential" missing
PasswordCredential interface: existence and properties of interface prototype object's "constructor" property FAIL assert_own_property: self does not have own property "PasswordCredential" expected property "PasswordCredential" missing
PasswordCredential interface: attribute idName FAIL assert_own_property: self does not have own property "PasswordCredential" expected property "PasswordCredential" missing
PasswordCredential interface: attribute passwordName FAIL assert_own_property: self does not have own property "PasswordCredential" expected property "PasswordCredential" missing
PasswordCredential interface: attribute additionalData FAIL assert_own_property: self does not have own property "PasswordCredential" expected property "PasswordCredential" missing
PasswordCredential must be primary interface of new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: PasswordCredential is not defined"
Stringification of new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: PasswordCredential is not defined"
PasswordCredential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "idName" with the proper type (0) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: PasswordCredential is not defined"
PasswordCredential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "passwordName" with the proper type (1) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: PasswordCredential is not defined"
PasswordCredential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "additionalData" with the proper type (2) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: PasswordCredential is not defined"
PasswordCredential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "name" with the proper type (3) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: PasswordCredential is not defined"
PasswordCredential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "iconURL" with the proper type (4) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: PasswordCredential is not defined"
Credential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "id" with the proper type (0) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: PasswordCredential is not defined"
Credential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "type" with the proper type (1) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: PasswordCredential is not defined"
FederatedCredential interface: existence and properties of interface object FAIL assert_own_property: self does not have own property "FederatedCredential" expected property "FederatedCredential" missing
FederatedCredential interface object length FAIL assert_own_property: self does not have own property "FederatedCredential" expected property "FederatedCredential" missing
FederatedCredential interface object name FAIL assert_own_property: self does not have own property "FederatedCredential" expected property "FederatedCredential" missing
FederatedCredential interface: existence and properties of interface prototype object FAIL assert_own_property: self does not have own property "FederatedCredential" expected property "FederatedCredential" missing
FederatedCredential interface: existence and properties of interface prototype object's "constructor" property FAIL assert_own_property: self does not have own property "FederatedCredential" expected property "FederatedCredential" missing
FederatedCredential interface: attribute provider FAIL assert_own_property: self does not have own property "FederatedCredential" expected property "FederatedCredential" missing
FederatedCredential interface: attribute protocol FAIL assert_own_property: self does not have own property "FederatedCredential" expected property "FederatedCredential" missing
FederatedCredential must be primary interface of new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: FederatedCredential is not defined"
Stringification of new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: FederatedCredential is not defined"
FederatedCredential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "provider" with the proper type (0) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: FederatedCredential is not defined"
FederatedCredential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "protocol" with the proper type (1) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: FederatedCredential is not defined"
FederatedCredential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "name" with the proper type (2) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: FederatedCredential is not defined"
FederatedCredential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "iconURL" with the proper type (3) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: FederatedCredential is not defined"
Credential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "id" with the proper type (0) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: FederatedCredential is not defined"
Credential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "type" with the proper type (1) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: FederatedCredential is not defined"

@w3c-bots
Copy link

w3c-bots commented May 2, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision df14160
Using browser at version 60.0.3080.5 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/credential-management/idl.https.html
Subtest Results Messages
OK
CredentialsContainer interface: existence and properties of interface object PASS
CredentialsContainer interface object length PASS
CredentialsContainer interface object name PASS
CredentialsContainer interface: existence and properties of interface prototype object PASS
CredentialsContainer interface: existence and properties of interface prototype object's "constructor" property PASS
CredentialsContainer interface: operation get(CredentialRequestOptions) PASS
CredentialsContainer interface: operation store(Credential) PASS
CredentialsContainer interface: operation requireUserMediation() PASS
CredentialsContainer must be primary interface of navigator.credentials PASS
Stringification of navigator.credentials PASS
CredentialsContainer interface: navigator.credentials must inherit property "get" with the proper type (0) PASS
CredentialsContainer interface: calling get(CredentialRequestOptions) on navigator.credentials with too few arguments must throw TypeError PASS
CredentialsContainer interface: navigator.credentials must inherit property "store" with the proper type (1) PASS
CredentialsContainer interface: calling store(Credential) on navigator.credentials with too few arguments must throw TypeError PASS
CredentialsContainer interface: navigator.credentials must inherit property "requireUserMediation" with the proper type (2) PASS
PasswordCredential interface: existence and properties of interface object FAIL assert_equals: prototype of PasswordCredential is not Credential expected function "function Credential() { [native code] }" but got function "function SiteBoundCredential() { [native code] }"
PasswordCredential interface object length PASS
PasswordCredential interface object name PASS
PasswordCredential interface: existence and properties of interface prototype object FAIL assert_equals: prototype of PasswordCredential.prototype is not Credential.prototype expected object "[object Credential]" but got object "[object SiteBoundCredential]"
PasswordCredential interface: existence and properties of interface prototype object's "constructor" property PASS
PasswordCredential interface: attribute idName PASS
PasswordCredential interface: attribute passwordName PASS
PasswordCredential interface: attribute additionalData PASS
PasswordCredential must be primary interface of new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) PASS
Stringification of new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) PASS
PasswordCredential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "idName" with the proper type (0) PASS
PasswordCredential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "passwordName" with the proper type (1) PASS
PasswordCredential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "additionalData" with the proper type (2) FAIL Unrecognized type FormData
PasswordCredential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "name" with the proper type (3) PASS
PasswordCredential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "iconURL" with the proper type (4) PASS
Credential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "id" with the proper type (0) PASS
Credential interface: new PasswordCredential({ id: "id", password: "pencil", iconURL: "https://example.com/", name: "name" }) must inherit property "type" with the proper type (1) PASS
FederatedCredential interface: existence and properties of interface object FAIL assert_equals: prototype of FederatedCredential is not Credential expected function "function Credential() { [native code] }" but got function "function SiteBoundCredential() { [native code] }"
FederatedCredential interface object length PASS
FederatedCredential interface object name PASS
FederatedCredential interface: existence and properties of interface prototype object FAIL assert_equals: prototype of FederatedCredential.prototype is not Credential.prototype expected object "[object Credential]" but got object "[object SiteBoundCredential]"
FederatedCredential interface: existence and properties of interface prototype object's "constructor" property PASS
FederatedCredential interface: attribute provider PASS
FederatedCredential interface: attribute protocol PASS
FederatedCredential must be primary interface of new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) PASS
Stringification of new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) PASS
FederatedCredential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "provider" with the proper type (0) PASS
FederatedCredential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "protocol" with the proper type (1) PASS
FederatedCredential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "name" with the proper type (2) PASS
FederatedCredential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "iconURL" with the proper type (3) PASS
Credential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "id" with the proper type (0) PASS
Credential interface: new FederatedCredential({ id: "id", provider: "https://example.com", iconURL: "https://example.com/", name: "name" }) must inherit property "type" with the proper type (1) PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants