New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CM API IDL to use SecureContext #5755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements recent changes to the Credential Manager API specification that introduce the |SecureContext| extended attribute on its interfaces. Furthermore it removes |RuntimeEnabled=CredentialManager| from the interfaces following the discussion in http://crrev.com/2832813002. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/-E-O9LgsPfM/ExJ7hiY1BQAJ BUG=715077 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2844453002 Cr-Commit-Position: refs/heads/master@{#468596}
Firefox (nightly channel)Testing web-platform-tests at revision df14160 All results1 test ran/credential-management/idl.https.html
|
Chrome (unstable channel)Testing web-platform-tests at revision df14160 All results1 test ran/credential-management/idl.https.html
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements recent changes to the Credential Manager API
specification that introduce the |SecureContext| extended attribute on
its interfaces. Furthermore it removes
|RuntimeEnabled=CredentialManager| from the interfaces following the
discussion in http://crrev.com/2832813002.
Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/-E-O9LgsPfM/ExJ7hiY1BQAJ
BUG=715077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2844453002
Cr-Commit-Position: refs/heads/master@{#468596}
This change is