Extend cssom/CSSKeyframeRule.html to test that style attribute has [P… #6184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
zcorpan,
dbaron,
lilles,
therealglazou,
plinss and
a user
Firefox (nightly)Testing web-platform-tests at revision 927e608 All results1 test ran/cssom/CSSKeyframeRule.html
|
Sauce (safari)Testing web-platform-tests at revision 927e608 All results1 test ran/cssom/CSSKeyframeRule.html
|
Chrome (unstable)Testing web-platform-tests at revision 927e608 All results1 test ran/cssom/CSSKeyframeRule.html
|
Sauce (MicrosoftEdge)Testing web-platform-tests at revision 927e608 All results1 test ran/cssom/CSSKeyframeRule.html
|
hubot
pushed a commit
to WebKit/WebKit-http
that referenced
this pull request
Jun 8, 2017
… be settable https://bugs.webkit.org/show_bug.cgi?id=164537 <rdar://problem/29181773> Reviewed by Sam Weinig. LayoutTests/imported/w3c: * web-platform-tests/cssom/CSSKeyframeRule-expected.txt: * web-platform-tests/cssom/CSSKeyframeRule.html: * web-platform-tests/cssom/CSSStyleRule-expected.txt: * web-platform-tests/cssom/CSSStyleRule.html: Re-sync web-platform tests after: - web-platform-tests/wpt#6181 - web-platform-tests/wpt#6184 This extends test coverage. * web-platform-tests/cssom/interfaces-expected.txt: Rebaseline now that more checks are passing. Source/WebCore: CSSStyleRule.style / CSSPageRule.style / CSSKeyframeRule.style should be settable as per: - https://drafts.csswg.org/cssom/#the-cssstylerule-interface - https://drafts.csswg.org/cssom/#the-csspagerule-interface - https://drafts.csswg.org/css-animations/#interface-csskeyframerule Tests: http/wpt/cssom/CSSPageRule.html imported/w3c/web-platform-tests/cssom/CSSKeyframeRule.html imported/w3c/web-platform-tests/cssom/CSSStyleRule.html imported/w3c/web-platform-tests/cssom/interfaces.html * css/CSSKeyframeRule.idl: * css/CSSPageRule.idl: * css/CSSStyleRule.idl: LayoutTests: Add better test coverage for CSSPageRule. This test is being upstreamed via: - web-platform-tests/wpt#6183 * http/wpt/cssom/CSSPageRule-expected.txt: Added. * http/wpt/cssom/CSSPageRule.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@217917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ghost
approved these changes
Jun 8, 2017
dbaron
approved these changes
Jun 8, 2017
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
… be settable https://bugs.webkit.org/show_bug.cgi?id=164537 <rdar://problem/29181773> Reviewed by Sam Weinig. LayoutTests/imported/w3c: * web-platform-tests/cssom/CSSKeyframeRule-expected.txt: * web-platform-tests/cssom/CSSKeyframeRule.html: * web-platform-tests/cssom/CSSStyleRule-expected.txt: * web-platform-tests/cssom/CSSStyleRule.html: Re-sync web-platform tests after: - web-platform-tests/wpt#6181 - web-platform-tests/wpt#6184 This extends test coverage. * web-platform-tests/cssom/interfaces-expected.txt: Rebaseline now that more checks are passing. Source/WebCore: CSSStyleRule.style / CSSPageRule.style / CSSKeyframeRule.style should be settable as per: - https://drafts.csswg.org/cssom/#the-cssstylerule-interface - https://drafts.csswg.org/cssom/#the-csspagerule-interface - https://drafts.csswg.org/css-animations/#interface-csskeyframerule Tests: http/wpt/cssom/CSSPageRule.html imported/w3c/web-platform-tests/cssom/CSSKeyframeRule.html imported/w3c/web-platform-tests/cssom/CSSStyleRule.html imported/w3c/web-platform-tests/cssom/interfaces.html * css/CSSKeyframeRule.idl: * css/CSSPageRule.idl: * css/CSSStyleRule.idl: LayoutTests: Add better test coverage for CSSPageRule. This test is being upstreamed via: - web-platform-tests/wpt#6183 * http/wpt/cssom/CSSPageRule-expected.txt: Added. * http/wpt/cssom/CSSPageRule.html: Added. Canonical link: https://commits.webkit.org/189941@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@217917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…utForwards]