Streams: Check constructor and method names #7035
Conversation
Check the .name properties of constructors and methods for the Streams API. Also add properties tests for ReadableByteStreamController, ReadableStreamBYOBReader and ReadableStreamBYOBRequest.
wpt-pr-bot
requested review from
calvaris,
domenic,
tyoshino,
wanderview,
youennf and
yutakahirano
Build PASSEDStarted: 2017-08-29 11:39:35 Failing Jobs
View more information about this build on: |
| assert_array_equals(Object.getOwnPropertyNames(proto).sort(), properties); | ||
|
|
||
| for (const m of methods) { | ||
| const propDesc = Object.getOwnPropertyDescriptor(proto, m); |
There was a problem hiding this comment.
Lots of duplication here and elsewhere, but meh...
There was a problem hiding this comment.
I know. I wanted to use the structure I used in writable-streams/properties.js but the need to fetch ReadableStreamBYOBRequest asynchronously meant it wouldn't work directly. So then I just decided to go ahead and land this before the scope creep got any worse.
|
I'm a bit worried that the Travis failures for Safari and Edge might mean the test never completes on those browsers. Does w-p-t have a way of dealing with that if I merge this change? |
|
My interpretation was that the WPT infra is just broken and not running tests in any browsers. (Since Chrome is not working either.) Let me ask in #testing IRC to see what's up. |
|
gsnedders helpfully said
So I think we can merge this. |
Check the .name properties of constructors and methods for the Streams API.
Also add properties tests for ReadableByteStreamController,
ReadableStreamBYOBReader and ReadableStreamBYOBRequest.