Implemented: remove browsing context name on cross origin navigation #7072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 31, 2017
Build PASSEDStarted: 2017-10-05 13:16:01 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-I70cb3efcef06a3442ed4bf9ddd3733e24ccde19d
branch
2 times, most recently
from
a0bc1e1
to
77ddd7c
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-I70cb3efcef06a3442ed4bf9ddd3733e24ccde19d
branch
from
77ddd7c
to
c3bf9fe
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-I70cb3efcef06a3442ed4bf9ddd3733e24ccde19d
branch
2 times, most recently
from
6190021
to
4a42729
Compare
When updating the history after a cross-origin navigation, the HTML Standard says: "If the browsing context is a top-level browsing context, but not an auxiliary browsing context, then set the browsing context's name to the empty string." Currently we are not doing this which means there's potential information leak. Spec: https://html.spec.whatwg.org/multipage/browsers.html#resetBCName I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/fhUIycdlINU/RLVEOKaNAwAJ Webkit change: https://trac.webkit.org/changeset/209076/webkit Bug: crbug.com/706350 Change-Id: I70cb3efcef06a3442ed4bf9ddd3733e24ccde19d Reviewed-on: https://chromium-review.googlesource.com/645309 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#506708}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-I70cb3efcef06a3442ed4bf9ddd3733e24ccde19d
branch
from
4a42729
to
05eba5a
Compare
chromium-wpt-export-bot
deleted the
chromium-export-cl-I70cb3efcef06a3442ed4bf9ddd3733e24ccde19d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the history after a cross-origin navigation, the HTML
Standard says: "If the browsing context is a top-level browsing context,
but not an auxiliary browsing context, then set the browsing context's
name to the empty string."
Currently we are not doing this which means there's potential
information leak.
Spec: https://html.spec.whatwg.org/multipage/browsers.html#resetBCName
I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/fhUIycdlINU/RLVEOKaNAwAJ
Webkit change: https://trac.webkit.org/changeset/209076/webkit
Bug: crbug.com/706350
Change-Id: I70cb3efcef06a3442ed4bf9ddd3733e24ccde19d
Reviewed-on: https://chromium-review.googlesource.com/645309
Commit-Queue: Andy Paicu andypaicu@chromium.org
Reviewed-by: Mike West mkwst@chromium.org
Cr-Commit-Position: refs/heads/master@{#506708}