Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: remove browsing context name on cross origin navigation #7072

Commits on Oct 5, 2017

  1. Implemented: remove browsing context name on cross origin navigation

    When updating the history after a cross-origin navigation, the HTML
    Standard says: "If the browsing context is a top-level browsing context,
    but not an auxiliary browsing context, then set the browsing context's
    name to the empty string."
    
    Currently we are not doing this which means there's potential
    information leak.
    
    Spec: https://html.spec.whatwg.org/multipage/browsers.html#resetBCName
    I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/fhUIycdlINU/RLVEOKaNAwAJ
    Webkit change:  https://trac.webkit.org/changeset/209076/webkit
    
    Bug: crbug.com/706350
    Change-Id: I70cb3efcef06a3442ed4bf9ddd3733e24ccde19d
    Reviewed-on: https://chromium-review.googlesource.com/645309
    Commit-Queue: Andy Paicu <andypaicu@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#506708}
    andypaicu authored and chromium-wpt-export-bot committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    05eba5a View commit details
    Browse the repository at this point in the history