Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iframe support for test runner #728

Closed
wants to merge 1 commit into from
Closed

Add iframe support for test runner #728

wants to merge 1 commit into from

Conversation

jcxia43
Copy link
Contributor

@jcxia43 jcxia43 commented Mar 7, 2014

This is to add test runner an optional feature of running tests in an iframe while keeping running tests in a top-level browsing context as default.
It makes the test runner work smoothly in Web Runtime, and benefits reftests and manual tests running on mobile devices by saving tab/window switching operations

@jcxia43 jcxia43 added the infra label Mar 7, 2014
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/955

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jcxia43
Copy link
Contributor Author

jcxia43 commented Mar 7, 2014

@jgraham , Would you please review it? Thanks indeed.

@jgraham
Copy link
Contributor

jgraham commented Mar 21, 2014

I'm pretty sure that this is a bad idea. Some tests depend on being in a top level browsing context, so it's wrong to run them in an iframe. For running on mobile you really want something automated for all the non-manual tests, in the style of [1](only runs testharness tests on mobile at the moment but should eventually support reftests too. Also very beta and entirely Mozilla-specific)

[1] https://pypi.python.org/pypi/wptrunner

@jcxia43
Copy link
Contributor Author

jcxia43 commented Mar 26, 2014

Thanks, got it.

@jcxia43 jcxia43 closed this Mar 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants