Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv payments policy tests to /feature-policy/ #7329

Merged
merged 2 commits into from
Sep 12, 2017

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Sep 12, 2017

@wpt-pr-bot
Copy link
Collaborator

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@w3c-bots
Copy link

w3c-bots commented Sep 12, 2017

Build PASSED

Started: 2017-09-12 01:34:22
Finished: 2017-09-12 01:35:03

Failing Jobs

  • MicrosoftEdge:14.14393

Unstable Results

Browser: "Microsoftedge 14.14393" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/feature-policy/payment-allowed-by-feature-policy-attribute.https.sub.html   OK: 6
  Feature policy "payment" can be enabled in cross-origin iframe using allow="payment" attribute FAIL: 6
Unable to get property 'concat' of undefined or null reference
  Feature policy "payment" can be enabled in same-origin iframe using allow="payment" attribute FAIL: 6
Unable to get property 'concat' of undefined or null reference
/feature-policy/payment-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html   OK: 6
  Feature-Policy allow="payment" allowpaymentrequest=true allows same-origin relocation. FAIL: 6
Unable to get property 'concat' of undefined or null reference
  Feature-Policy allow="payment" allowpaymentrequest=true disallows cross-origin relocation. FAIL: 6
Unable to get property 'concat' of undefined or null reference
  Feature-Policy allow="payment" allows same-origin relocation. FAIL: 6
Unable to get property 'concat' of undefined or null reference
  Feature-Policy allow="payment" disallows cross-origin relocation. FAIL: 6
Unable to get property 'concat' of undefined or null reference
/feature-policy/payment-allowed-by-feature-policy.https.sub.html   TIMEOUT: 6
/feature-policy/payment-default-feature-policy.https.sub.html   TIMEOUT: 6
/feature-policy/payment-disabled-by-feature-policy.https.sub.html   TIMEOUT: 6

Copy link
Contributor

@clelland clelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pattern repeats for a large number of other APIs, we may want to move this into /feature-policy/features/payment-request/ or something similar, but I don't think there's any need to impose that kind of structure yet.

@clelland
Copy link
Contributor

(Also, I may not be allowed to approve the change that makes me an owner -- it might have to be done in two steps, or someone else may need to approve this one)

@marcoscaceres
Copy link
Contributor Author

cc @sideshowbarker for super powers.

@marcoscaceres
Copy link
Contributor Author

If this pattern repeats for a large number of other APIs, we may want to move this into /feature-policy/features/payment-request/ or something similar, but I don't think there's any need to impose that kind of structure yet.

Agree. That would be nice. I'm not a huge fan of the tests with the massively long filenames. Prefer they were in nicely organized folders.

@marcoscaceres marcoscaceres merged commit c98ac0c into master Sep 12, 2017
@marcoscaceres marcoscaceres deleted the payments_feature_policy branch September 12, 2017 02:59
rachelandrew pushed a commit to rachelandrew/web-platform-tests that referenced this pull request Nov 8, 2017
jakearchibald pushed a commit to jakearchibald/web-platform-tests that referenced this pull request Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-origin Payment Request in Payment Allowed By Feature Policy
5 participants