Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Motion Path: begin path at offset-position #7362

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 16, 2017

When offset-position is not 'auto', the path begins at offset-position.

When offset-position is not 'auto', but offset-path is 'none', we have a
simple translation to offset-position. In this case, offset-anchor uses
the same value as offset-position, but with percentages referring to
the element's width/height and not the containing block's width/height.

Spec:
https://drafts.fxtf.org/motion-1/#offset-position-property
https://drafts.fxtf.org/motion-1/#offset-anchor-property

Work remaining:
For this initial implementation, we use the parent layout object
instead of the true containing block.

(When an element is absolutely positioned and the parent element is the
containing block, these are the same.)

BUG=638055

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I53e5b576adebf65ede8ebd1dabe084713ebdf875

Reviewed-on: https://chromium-review.googlesource.com/666945
WPT-Export-Revision: bac07975d1f07ff9ea4bf334bfb507fcb4989bc0

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@w3c-bots
Copy link

w3c-bots commented Sep 16, 2017

Build PASSED

Started: 2017-10-03 02:21:56
Finished: 2017-10-03 02:27:10

Failing Jobs

  • safari:10.0
  • MicrosoftEdge:14.14393

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-I53e5b576adebf65ede8ebd1dabe084713ebdf875 branch 2 times, most recently from 08baf27 to f441a8b Compare September 20, 2017 04:50
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-I53e5b576adebf65ede8ebd1dabe084713ebdf875 branch from f441a8b to 81f67f2 Compare October 2, 2017 02:14
When offset-position is not 'auto', the path begins at offset-position.

When offset-position is not 'auto', but offset-path is 'none', we have a
simple translation to offset-position. In this case, offset-anchor uses
the same value as offset-position, but with percentages referring to
the element's width/height and not the containing block's width/height.

Spec:
https://drafts.fxtf.org/motion-1/#offset-position-property
https://drafts.fxtf.org/motion-1/#offset-anchor-property

Work remaining:
For this initial implementation, we use the parent layout object
instead of the true containing block.

(When an element is absolutely positioned and the parent element is the
containing block, these are the same.)

BUG=638055

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I53e5b576adebf65ede8ebd1dabe084713ebdf875
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-I53e5b576adebf65ede8ebd1dabe084713ebdf875 branch from 81f67f2 to 2d080f1 Compare October 3, 2017 02:21
@KyleJu
Copy link
Contributor

KyleJu commented Feb 5, 2019

Close this PR because thi is a Stale chromium-export PR/branche.

@KyleJu KyleJu closed this Feb 5, 2019
@KyleJu KyleJu deleted the chromium-export-cl-I53e5b576adebf65ede8ebd1dabe084713ebdf875 branch February 5, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants