-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebAuthn WD-05 API updates #7500
WebAuthn WD-05 API updates #7500
Conversation
There are no owners for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
Build PASSEDStarted: 2018-01-10 19:29:18 View more information about this build on: |
Note in Firefox Nightly these changes cause both getcredential-passing.https.html and getcredential-passing.https.html to pass, and most of interfaces.https.html to pass as well. createcredential-badargs-rp.https.html has some other issues which should be addressed in a different commit.
Hi, I'm one of the WebAuthn editors, and implementing this feature in Firefox. This patch is good, though we also need to make some updates to come to WD-07. I submitted a different PR to @apowers313 at apowers313#1 to add one more patch on top of these, but I'm fine with merging this and then opening a PR to pull in b6807f1 |
Updates per WD-07.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these need more work, but they are strictly better than what is currently in-tree, so let's move this forward.
Updates to tests based on the WD-05 spec. These are mostly the tests that were run at the interop, with a few new ones added: secure context tests,
credentials.get()
tests, and passing badrp
arguments tocredentials.create()
.