WebAuthn WD-05 API updates #7500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no owners for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
Build PASSEDStarted: 2018-01-10 19:29:18 View more information about this build on: |
Note in Firefox Nightly these changes cause both getcredential-passing.https.html and getcredential-passing.https.html to pass, and most of interfaces.https.html to pass as well. createcredential-badargs-rp.https.html has some other issues which should be addressed in a different commit.
|
Hi, I'm one of the WebAuthn editors, and implementing this feature in Firefox. This patch is good, though we also need to make some updates to come to WD-07. I submitted a different PR to @apowers313 at apowers313#1 to add one more patch on top of these, but I'm fine with merging this and then opening a PR to pull in b6807f1 |
Updates per WD-07.
jcjones
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to tests based on the WD-05 spec. These are mostly the tests that were run at the interop, with a few new ones added: secure context tests,
credentials.get()tests, and passing badrparguments tocredentials.create().