wai-aria: Fix bug in test generator and regenerate tests #7540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make_tests.pl assumed that a row count would proceed each accessibility API in the assertion table. Because it is not necessary to specify the row count when there is only one row, some test writers failed to do so. As a result, we were winding up with one API's assertions becoming part of the previous API's. In order to make generation a bit more reliable, match on the presence of the API name at the end of the string and then look for a row count, defaulting to 1.
Build PASSEDStarted: 2017-10-02 14:02:22 View more information about this build on: |
halindrome
approved these changes
Oct 2, 2017
jakearchibald
pushed a commit
to jakearchibald/web-platform-tests
that referenced
this pull request
Nov 16, 2017
…m-tests#7540) * wai-aria/tools Handle unspecified API row count in make_tests.pl make_tests.pl assumed that a row count would proceed each accessibility API in the assertion table. Because it is not necessary to specify the row count when there is only one row, some test writers failed to do so. As a result, we were winding up with one API's assertions becoming part of the previous API's. In order to make generation a bit more reliable, match on the presence of the API name at the end of the string and then look for a row count, defaulting to 1. * wai-aria: Fix errors in tests for IAccessible2 and MSAA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.