Consistently use spaces in object notation; #7808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be standard JS style recently (as used in prettier etc.): Use
spaces to separate the { and } from the properties (but not for arrays).
MozReview-Commit-ID: FRkFRwwcJJh
Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1402170 [ci skip]
|
Code reviewed upstream. |
snuggs
reviewed
Nov 9, 2017
| @@ -45,7 +45,7 @@ | |||
|
|
|||
| Object.defineProperty(this, testProp, { | |||
| get: function() { _propAccessCount++; }, | |||
| enumerable: true | |||
| enumerable: true, | |||
There was a problem hiding this comment.
@jgraham why no trailing commas in all object literals? Or the inclusion of this one?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Trailing_commas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be standard JS style recently (as used in prettier etc.): Use
spaces to separate the { and } from the properties (but not for arrays).
MozReview-Commit-ID: FRkFRwwcJJh
Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1402170 [ci skip]