Implement Send Alert Text tests for WPT wdspec tests #8155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
andreastt,
AutomatedTester,
kereliuk,
lukeis,
mjzffr and
shs96c
andreastt
requested changes
Nov 11, 2017
| "number": 123} | ||
| session.execute_script("window.result = window.prompt(\"Enter Your Name: \", \"Name\");") | ||
| for item in elements: | ||
| body = {"text": elements[item]} |
There was a problem hiding this comment.
This iterator is not very Pythonic. Can you change the test to use @pytest.parametrize?
This would look roughly something like this:
@pytest.parametrize("text", [None, {}, [], 42, True])
def test_invalid_input(session, text):
session.execute_script("""window.result = window.prompt("foo")""")
response = send_alert_text(session, {"text": text})
assert_error(response, "invalid argument")Note that I haven’t run the above code.
|
Also, there are conflicts which you must resolve. |
delete trailing whitespace Deleted unused import. Simplified send alert text test. Test non string input. Test text with whitespace. Formatting fixes. Add more tests for invalid input Initiate the prompt once only Parametrize invalid input test
Build PASSEDStarted: 2017-11-13 21:59:17 Failing Jobs
View more information about this build on: |
andreastt
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete trailing whitespace
Deleted unused import. Simplified send alert text test.
Test non string input. Test text with whitespace. Formatting fixes.
Add more tests for invalid input