FetchEvent.clientID is an empty string by default and no longer nullable #8289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build PASSEDStarted: 2017-12-06 20:39:10 View more information about this build on: |
|
It looks good. I think it's better to change the error message from "non-null" to "non-empty string" or similar too. |
|
Ping review? |
|
ping review? See related #8507 |
youennf
force-pushed
the
fix-client-id-empty-string
branch
from
946f278
to
a0daa57
Compare
beidson
approved these changes
Dec 7, 2017
hubot
pushed a commit
to WebKit/WebKit-http
that referenced
this pull request
Dec 12, 2017
https://bugs.webkit.org/show_bug.cgi?id=179808 Patch by Youenn Fablet <youenn@apple.com> on 2017-12-12 Reviewed by Chris Dumez. LayoutTests/imported/w3c: * web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt: * web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt: * web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt: * web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt: This is a progression since test is failing at a later point. Test might need being updated to match latest fetch spec. * web-platform-tests/service-workers/service-worker/resources/clients-get-worker.js: (self.onfetch): Change upstreamed at web-platform-tests/wpt#8289. Source/WebCore: Covered by existing tests. * Modules/fetch/FetchRequest.cpp: (WebCore::buildOptions): Update to throw only if init.mode is Navigate. * Modules/fetch/FetchRequestInit.h: (WebCore::FetchRequestInit::hasMembers const): If init is present, set default values as per spec. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::loadMainResource): Set fetch mode to navigate. * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Bypass preflight in case fetch mode is navigate. LayoutTests: * http/tests/workers/service/basic-fetch.https-expected.txt: * http/tests/workers/service/resources/basic-fetch-worker.js: * http/tests/workers/service/resources/basic-fetch.js: (async.test): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@225796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.