Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing clientId checks from null to empty string #8507

Merged
merged 1 commit into from Dec 7, 2017
Merged

Changing clientId checks from null to empty string #8507

merged 1 commit into from Dec 7, 2017

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Nov 29, 2017 •
edited by wpt-pr-bot

No description provided.

@w3c-bots
Copy link

w3c-bots commented Nov 29, 2017 •
edited

Build PASSED

Started: 2017-12-06 20:45:09
Finished: 2017-12-06 20:59:53

View more information about this build on:

@youennf
Copy link
Contributor Author

youennf commented Nov 30, 2017

ping review.

@youennf youennf mentioned this pull request Nov 30, 2017
Closed
@cdumez
Copy link
Contributor

cdumez commented Dec 5, 2017

LGTM. Could someone please merge?

@beidson beidson merged commit 56a44e9 into web-platform-tests:master Dec 7, 2017
@youennf youennf deleted the sw-client-id-null-checks branch December 7, 2017 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beidson beidson beidson approved these changes

@ehsan ehsan Awaiting requested review from ehsan

@mfalken mfalken Awaiting requested review from mfalken

@mkruisselbrink mkruisselbrink Awaiting requested review from mkruisselbrink

Assignees
No one assigned
Labels
service-workers wg-sw
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@youennf @w3c-bots @cdumez @beidson @wpt-pr-bot