Add first-letter test for combining characters #8939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build PASSEDStarted: 2018-01-07 03:17:37 View more information about this build on: |
In the process of creating https://chromium-review.googlesource.com/c/chromium/src/+/847293, I noticed that there was no first-letter test for combining characters with punctuation and letters. This change adds in such a test.
|
Note we have all of |
|
This is actually based off of https://github.com/w3c/web-platform-tests/blob/master/css/CSS2/selectors/first-letter-punctuation-173.xht, but with combining characters added. Since the combining characters act upon the punctuation and the first letter itself in this test, it is possible that implementations could pass all of the |
|
For some reason I thought some of the punctuation tests had combining characters in them. Bleh. |
gsnedders
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of creating https://chromium-review.googlesource.com/c/chromium/src/+/847293, I noticed that there was no first-letter test for combining characters with punctuation and letters. This change adds in such a test.
Submitted directly as Chromium does not import css-pseudo yet.