[PaintWorklet] Do null check for document paint definition #9078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 18, 2018
Build PASSEDStarted: 2018-01-19 07:00:41 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-869891
branch
4 times, most recently
from
96a5a79
to
9eda9f6
Compare
In quite a few functions in the CSSPaintImageGeneratorImpl class, we check whether the document paint definition of a particular name exists or not, but we never do null check on that definition. This could lead to crash if the document paint definition is a null ptr. This CL fixes the problem by doing null check. It also changes one layout test to execise this code path. The change to the layout test also fixes the problem that this layout test passes in the browser that doesn't support paint worklet. Bug: 802970, 768683 Change-Id: Ia952ad977b63af643410b0973cc8034fac504f9f Reviewed-on: https://chromium-review.googlesource.com/869891 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#530441}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-869891
branch
from
9eda9f6
to
fe9aa1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In quite a few functions in the CSSPaintImageGeneratorImpl class, we
check whether the document paint definition of a particular name exists
or not, but we never do null check on that definition. This could lead
to crash if the document paint definition is a null ptr.
This CL fixes the problem by doing null check. It also changes one
layout test to execise this code path. The change to the layout test
also fixes the problem that this layout test passes in the browser
that doesn't support paint worklet.
Bug: 802970, 768683
Change-Id: Ia952ad977b63af643410b0973cc8034fac504f9f
Reviewed-on: https://chromium-review.googlesource.com/869891
Commit-Queue: Xida Chen xidachen@chromium.org
Reviewed-by: Robert Flack flackr@chromium.org
Reviewed-by: Stephen McGruer smcgruer@chromium.org
Cr-Commit-Position: refs/heads/master@{#530441}