service worker: Disallow opaque responses for WebVTT. #9436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 8, 2018
Build PASSEDStarted: 2018-02-09 04:18:38 View more information about this build on: |
WebVTT loading code was determining if a response was cross-origin by looking at request URL. But a service worker may have intercepted the request and provided a response from cross-origin. Bug: 808825 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia121c0a8eae782de93d9777603426500a9709f8c Reviewed-on: https://chromium-review.googlesource.com/907013 Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#535625}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-907013
branch
from
2374f1e
to
355af21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebVTT loading code was determining if a response was cross-origin by looking
at request URL. But a service worker may have intercepted the request and
provided a response from cross-origin.
Bug: 808825
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia121c0a8eae782de93d9777603426500a9709f8c
Reviewed-on: https://chromium-review.googlesource.com/907013
Reviewed-by: Tsuyoshi Horo horo@chromium.org
Reviewed-by: Kinuko Yasuda kinuko@chromium.org
Commit-Queue: Matt Falkenhagen falken@chromium.org
Cr-Commit-Position: refs/heads/master@{#535625}