[css-typed-om] Implement shorthands for StylePropertyMap.set/delete. #9682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 27, 2018
Build PASSEDStarted: 2018-03-01 02:52:16 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-938684
branch
2 times, most recently
from
5a27bc8
to
6543527
Compare
This patch implements shorthands for stylemap.set/delete. When we receive an UnsupportedShorthandProperty, we should get the CSSValues out of them and set them on the style map. We leave parsing of shorthand values for a future patch. Bug: 816722 Change-Id: Iebd0b33f89b1d8872bea5d3f80d1dde71d72bc45 Reviewed-on: https://chromium-review.googlesource.com/938684 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#539992}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-938684
branch
from
6543527
to
6dcbf89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements shorthands for stylemap.set/delete. When we
receive an UnsupportedShorthandProperty, we should get the CSSValues
out of them and set them on the style map.
We leave parsing of shorthand values for a future patch.
Bug: 816722
Change-Id: Iebd0b33f89b1d8872bea5d3f80d1dde71d72bc45
Reviewed-on: https://chromium-review.googlesource.com/938684
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#539992}