Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add idlharness test for CSS Device Adaptation #9770

Merged
merged 10 commits into from Sep 11, 2018
Merged

Add idlharness test for CSS Device Adaptation #9770

merged 10 commits into from Sep 11, 2018

Conversation

lukebjerring
Copy link
Contributor

@lukebjerring lukebjerring commented Mar 2, 2018 •
edited by foolip

Uses the IDL file from #12911.

@w3c-bots
Copy link

w3c-bots commented Mar 2, 2018 •
edited

Build PASSED

Started: 2018-03-07 23:24:54
Finished: 2018-03-07 23:33:01

View more information about this build on:

@lukebjerring lukebjerring force-pushed the idl-file-updates-css-device-adapt branch from 03ee78f to 966871b Compare March 7, 2018 20:21
@domenic domenic removed their request for review April 20, 2018 21:14
@lukebjerring lukebjerring added this to In progress in Improve idlharness.js Jun 18, 2018
@lukebjerring lukebjerring moved this from In progress to To do in Improve idlharness.js Jun 18, 2018
@lukebjerring lukebjerring moved this from To do to In progress in Improve idlharness.js Jun 28, 2018
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@lukebjerring
Copy link
Contributor Author

@ChumpChief - I don't seem to be able to add you as a reviewer. @foolip do you know why that is?

@foolip
Copy link
Member

foolip commented Jul 16, 2018

That's because @ChumpChief isn't a member of the web-platform-tests org. I've sent an invite which can be accepted at https://github.com/web-platform-tests.

foolip
foolip reviewed Aug 4, 2018
View reviewed changes
css/css-device-adapt/META.yml Outdated
spec: https://drafts.csswg.org/css-device-adapt/
suggested_reviewers:
- ChumpChief
- frivoal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frivoal I see you are listed as editor of CSS Device Adaptation, would you like to get reviews for this directory?

@foolip foolip force-pushed the idl-file-updates-css-device-adapt branch from 3e97ddc to 95e2af4 Compare August 4, 2018 21:19
@foolip foolip requested a review from frivoal August 4, 2018 21:22
@foolip foolip mentioned this pull request Sep 10, 2018
Merged
@lukebjerring lukebjerring force-pushed the idl-file-updates-css-device-adapt branch from 931918f to b6352d2 Compare September 10, 2018 22:05
@foolip foolip changed the title Update the css-device-adapt IDL file Add idlharness test for CSS Device Adaptation Sep 11, 2018
foolip
foolip approved these changes Sep 11, 2018
View reviewed changes
css/css-device-adapt/META.yml Show resolved Hide resolved
@foolip
Copy link
Member

foolip commented Sep 11, 2018

@ChumpChief has confirmed over email he's OK with this, so I'll change META.yml back.

@foolip foolip merged commit 93fe0ed into web-platform-tests:master Sep 11, 2018
Improve idlharness.js automation moved this from In progress to Done Sep 11, 2018
@lukebjerring lukebjerring deleted the idl-file-updates-css-device-adapt branch October 5, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

@frivoal frivoal Awaiting requested review from frivoal

Assignees
No one assigned
Labels
css-device-adapt interfaces status:needs-reviewers wg-css
Projects
No open projects
Improve idlharness.js
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukebjerring @w3c-bots @wpt-pr-bot @foolip