Update the gamepad IDL file #9785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out this file is in sync with the spec, and that these are only indentation differences. https://github.com/w3c/gamepad/blob/gh-pages/index.html has that indentation, but it doesn't affect https://w3c.github.io/gamepad/#gamepadbutton-interface. I don't think we should pretty print (parse and serialize) the IDL if it can be avoided. A pretty good heuristic might be: If the first line of each IDL fragment starts with N spaces, and every subsequent line has no non-whitespace in the first N characters, then remove N spaces from the beginning of all lines. |
lukebjerring
force-pushed
the
idl-file-updates-gamepad
branch
from
3baf0b2
to
012e6a9
Compare
Build PASSEDStarted: 2018-03-08 02:30:59 View more information about this build on: |
foolip
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.