Computed min-width/height for auto depends on box. #9816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 5, 2018
Build PASSEDStarted: 2018-03-06 11:49:28 Failing Jobs
View more information about this build on: |
Resolved value of min-width and min-height for auto min sizing of flex and grid items may be 'auto'. We based this on the computed style of the shadow including parent. Instead we should rely on whether the element will actually be a rendered flex/grid item. Firefox Nightly passes all added tests. The mentioned bug fixed is actually about using the shadow including parent for finding parent computed style instead of the flat tree parent, but that is no longer relevant as we look at the layout tree. Bug: 682869 Change-Id: I6e47dc264a8cdbee7fc1983ce452baf7c0df85b3 Reviewed-on: https://chromium-review.googlesource.com/948908 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#540901}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-948908
branch
from
b11ff15
to
a0dee15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved value of min-width and min-height for auto min sizing of flex
and grid items may be 'auto'. We based this on the computed style of the
shadow including parent. Instead we should rely on whether the element
will actually be a rendered flex/grid item.
Firefox Nightly passes all added tests.
The mentioned bug fixed is actually about using the shadow including
parent for finding parent computed style instead of the flat tree
parent, but that is no longer relevant as we look at the layout tree.
Bug: 682869
Change-Id: I6e47dc264a8cdbee7fc1983ce452baf7c0df85b3
Reviewed-on: https://chromium-review.googlesource.com/948908
Reviewed-by: Morten Stenshorne mstensho@chromium.org
Commit-Queue: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/master@{#540901}