Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ids for the Chinese translation #480

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Add more ids for the Chinese translation #480

merged 1 commit into from
Sep 4, 2020

Conversation

xfq
Copy link
Member

@xfq xfq commented Sep 4, 2020

It would be better if these ids can be automatically generated, but before that happens, I would like to add these more semantic ids (comparing with the ones generated by generate-utils.js) to the Chinese translation.

Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for this. I added #483 to track the feature.

@tidoust tidoust merged commit 7886479 into master Sep 4, 2020
@xfq xfq deleted the xfq/chinese-id branch September 4, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants