Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: inform people that l2 is folded into main spec #134

Merged
merged 5 commits into from
Sep 23, 2020

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Nov 18, 2019

Closes #107

The level 2 spec is starting to show up in places, so we should merge this sooner rather than later to minimize the damage.


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Sep 22, 2020, 10:51 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

�[33m🕵️‍♀️  That doesn't seem to be a ReSpec document. Please check manually:�[39m �[36m[Function: url]�[39m

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@mgiuca
Copy link
Collaborator

mgiuca commented Nov 18, 2019

It isn't yet folded into the spec, right? So this is just deleting content that isn't available anywhere else (then we'll have to fish it out of revision control when we fold it into the spec). I think we should hold off on this.

to minimize the damage

What damage? If we eventually make the l2 spec just tell people to look at the l1 spec (i.e., land this change), then it doesn't matter if people are linking to the l2 spec for now.

@marcoscaceres
Copy link
Member Author

It isn't yet folded into the spec, right?

Correct, we need to land #133.

What damage?

Mostly broken links. We have for instance:
https://wiki.developer.mozilla.org/en-US/docs/Web/API/Navigator/canShare

(we don't have consensus on canShare() or the shape of that API - #108)

Which unfortunately was prematurely documented. Similarly talks about L2:
https://developers.google.com/web/updates/2019/05/web-share-files

then it doesn't matter if people are linking to the l2 spec for now.

Depends. The L2 will be out of sync with the published version and end up causing confusion (e.g., in the case of MDN).

@marcoscaceres marcoscaceres requested a review from mgiuca May 26, 2020 01:34
@marcoscaceres
Copy link
Member Author

@mgiuca, I'd really like for us to get this merged as canShare() keeps coming up and it's not part of the main spec. We can then finally get consensus on what canShare() will look like and how it will behave and land that in the main spec.

@marcoscaceres
Copy link
Member Author

Merging as #177 is now in place.

@marcoscaceres marcoscaceres merged commit 2bbde9c into master Sep 23, 2020
@marcoscaceres marcoscaceres deleted the drop-level-2 branch September 23, 2020 08:11
@sideshowbarker
Copy link

2bbde9c broke a link in MDN to the Level 2 spec — in the Specifications table here:

https://developer.mozilla.org/en-US/docs/Web/API/Navigator/canShare#Specifications

…which links to https://w3c.github.io/web-share/level-2/#canshare-method

And since #177 hasn’t been merged yet, we don’t have any other working URL that we could change that link to.

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Oct 5, 2020

@sideshowbarker, canShare() might not make it into the spec. It's still tentative (and not fit for purpose). Mozilla will probably object to it being included for the reasons outlined in #108. See #184 as the proposed alternative.

@marcoscaceres
Copy link
Member Author

(i.e., canShare() was never part of an official spec, it was just an incubation... it should not have been documented on MDN as anything but experimental... why I talked about merging this back November 2019, "to minimize the damage").

sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Oct 6, 2020
This change marks the navigator.canShare() method as experimental:true
and standard_track:false, per w3c/web-share#134
and w3c/web-share#134 (comment) in
particular. In w3c/web-share@2bbde9c dropped it
as a specified feature (along with the entire Web Share Level 2 spec.)
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Oct 6, 2020
This change marks the navigator.canShare() method as experimental:true
and standard_track:false, per w3c/web-share#134
and w3c/web-share#134 (comment) in
particular. w3c/web-share@2bbde9c dropped it
as a specified feature (along with the entire Web Share Level 2 spec.)
@sideshowbarker
Copy link

canShare() might not make it into the spec. It's still tentative (and not fit for purpose). Mozilla will probably object to it being included for the reasons outlined in #108. See #184 as the proposed alternative.

(i.e., canShare() was never part of an official spec, it was just an incubation... it should not have been documented on MDN as anything but experimental... why I talked about merging this back November 2019, "to minimize the damage").

OK, thanks — given all that, I’ve raised mdn/browser-compat-data#6844 to mark it as experimental and nonstandard in BCD, and in https://wiki.developer.mozilla.org/en-US/docs/Web/API/Navigator/canShare$compare?to=1647398&from=1642438, I marked the MDN article similarly.

ddbeck pushed a commit to mdn/browser-compat-data that referenced this pull request Oct 15, 2020
This change marks the navigator.canShare() method as experimental:true
and standard_track:false, per w3c/web-share#134
and w3c/web-share#134 (comment) in
particular. w3c/web-share@2bbde9c dropped it
as a specified feature (along with the entire Web Share Level 2 spec.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop the levels/versioning
3 participants