Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[[store]] default implementation returns undefined, but maybe it should throw #218

Closed
nsatragno opened this issue Jul 4, 2023 · 0 comments
Closed

[[store]] default implementation returns undefined, but maybe it should throw #218

nsatragno opened this issue Jul 4, 2023 · 0 comments

Comments

@nsatragno
Copy link
Member

A credential's internal [[store]] method has a default implementation that returns undefined. However, in practice this throws an exception in blink. I think the latter makes more sense, as a developer trying to store a type of credential that is not supported should not be indistinguishable from success.
@nsatragno nsatragno mentioned this issue Jul 4, 2023
Merged
lukewarlow added a commit to lukewarlow/webappsec-credential-management that referenced this issue Jul 5, 2023
@lukewarlow
Change default store algorithm to throw (w3c#218)
cca7846
lukewarlow added a commit to lukewarlow/webappsec-credential-management that referenced this issue Jul 5, 2023
@lukewarlow
Change default store algorithm to throw (w3c#218)
38e5755
nsatragno pushed a commit that referenced this issue Jul 10, 2023
@lukewarlow
Change default store algorithm to throw (#218) (#219)
39cc9b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nsatragno