Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully active checks? #227

Open
marcoscaceres opened this issue Mar 5, 2024 · 3 comments · Fixed by #230
Open

Fully active checks? #227

marcoscaceres opened this issue Mar 5, 2024 · 3 comments · Fixed by #230

Comments

@marcoscaceres
Copy link
Member

Seems we might be missing a couple of fully active checks on .get(), .store(), .create() and store().

that is, is there are case for stealing a reference from an iframe's navigator.credential to attempt to use the API? (I don't imagine there is)

const iframe = document.querySelector("iframe");
const { credentials } = iframe.contentWindow.navigator;
iframe.remove(); // no longer fully active..

await credentials.get(someCredential); // probably reject with NotAllowedError
@marcoscaceres
Copy link
Member Author

marcoscaceres commented Mar 7, 2024

We might also want to deal with what happens when a credential UI is shown and the underlying document becomes non-fully-active (i.e., probably want to tear down any UI and AbortError promises or something).

@marcoscaceres
Copy link
Member Author

We probably need to add a promise reaction here too... to clear the active credential type.

@marcoscaceres
Copy link
Member Author

Reopening so we can add the reactions.

@marcoscaceres marcoscaceres reopened this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant