Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common checks #228

Open
marcoscaceres opened this issue Mar 5, 2024 · 0 comments
Open

Common checks #228

marcoscaceres opened this issue Mar 5, 2024 · 0 comments

Comments

@marcoscaceres
Copy link
Member

This is mostly a nit... but but it might be good to pull out the "common checks" or "pre-checks" done by .get(), .create(), and store():

  1. Assert: settings is a secure context.
  2. If options.signal is aborted, then return a promise rejected with options.signal’s abort reason.

And maybe bring in #227 into the above...

Also, I'm a bit dubious about the "Assert: settings is a secure context"... I mean, I get it... but given the it's done by the binding layer, is there ever any chance that it wouldn't be in SecureContext? (Wouldn't we have bigger problems if that ever happened?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant