Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use “navigable”+“parent”, not “parent browsing context”; fix fetch() refs #223

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Use “navigable”+“parent”, not “parent browsing context”; fix fetch() refs #223

merged 2 commits into from
Jul 12, 2023

Conversation

sideshowbarker
Copy link
Contributor

@sideshowbarker sideshowbarker commented Jul 7, 2023 •
edited by pr-preview bot

Fixes #213

Preview | Diff

@sideshowbarker
Copy link
Contributor Author

@domenic, can you please look this over when you can make time?

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/parent-browsing-context-to-parent-navigable branch from 0f3d896 to f893ee7 Compare July 7, 2023 21:45
@sideshowbarker sideshowbarker changed the title Stop using “parent browsing context”; instead use “parent navigable” Stop using “parent browsing context”; instead just use “navigable” and “parent” Jul 7, 2023
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/parent-browsing-context-to-parent-navigable branch 2 times, most recently from b5dd459 to d69fb24 Compare July 7, 2023 23:47
@sideshowbarker sideshowbarker changed the title Stop using “parent browsing context”; instead just use “navigable” and “parent” Use “navigable”+“parent”, not “parent browsing context”; fix fetch() refs Jul 7, 2023
@sideshowbarker
Copy link
Contributor Author

@annevk When you have time (particularly about the fetch() refs)

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/parent-browsing-context-to-parent-navigable branch from d69fb24 to ddd5952 Compare July 7, 2023 23:49
@w3cbot
Copy link

w3cbot commented Jul 8, 2023

sideshowbarker marked as non substantive for IPR from ash-nazg.

@w3c w3c deleted a comment from ASISBusiness Jul 10, 2023
domenic
domenic approved these changes Jul 12, 2023
View reviewed changes
Copy link

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits; thanks for working on this!

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@sideshowbarker
Copy link
Contributor Author

LGTM with nits; thanks for working on this!

Thanks — see the update I just now pushed, and lemme know if I got anything wrong

@sideshowbarker sideshowbarker merged commit a70bc66 into main Jul 12, 2023
2 checks passed
@sideshowbarker sideshowbarker deleted the sideshowbarker/parent-browsing-context-to-parent-navigable branch July 12, 2023 05:22
github-actions bot added a commit that referenced this pull request Jul 12, 2023
@sideshowbarker @github-actions
Use “navigable”+“parent”, not “parent browsing context”; fix fetch() …
7dc7773 
…refs (#223)

SHA: a70bc66
Reason: push, by sideshowbarker

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@ASISBusiness ASISBusiness ASISBusiness approved these changes

Assignees

@sideshowbarker sideshowbarker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix build
4 participants
@sideshowbarker @w3cbot @domenic @ASISBusiness