Add mediation to credential creation options #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eavy lifting of conditional in create is handled in WebAuthn. See also https://github.com/w3c/webauthn/pull/1951/files https://github.com/w3c/webauthn/wiki/Explainer:-Conditional-Registration-Extension
pascoej
changed the title
nsatragno
requested changes
Jan 31, 2024
Hmercer23
approved these changes
Feb 2, 2024
nsatragno
approved these changes
Feb 28, 2024
|
Thank you for the review! |
pascoej
force-pushed
the
cond-reg
branch
4 times, most recently
from
06d81f0
to
b6c2261
Compare
index.bs
Outdated
| {{Credential}}'s default implementation of {{Credential/willRequestConditionalCreation()}}: | ||
|
|
||
| <ol class="algorithm"> | ||
| 1. Return a new {{Promise}} that immediately [=resolves=]. |
There was a problem hiding this comment.
I think here you just want:
Suggested change
| 1. Return a new {{Promise}} that immediately [=resolves=]. | |
| 1. Return [=a promise resolved with=] undefined. |
The "immediately" could be confusing (it will happen "immediately", but let the underlying algorithm in WebIDL and JS handle that).
index.bs
Outdated
| 1. Return a new {{Promise}} that immediately [=resolves=]. | ||
| </ol> | ||
|
|
||
| Note: If this function is not present, {{CredentialMediationRequirement/conditional}} |
There was a problem hiding this comment.
This should probably be "method" or "operation"
Suggested change
| Note: If this function is not present, {{CredentialMediationRequirement/conditional}} | |
| Note: If this method is not present, {{CredentialMediationRequirement/conditional}} |
github-actions bot
added a commit
that referenced
this pull request
May 30, 2024
SHA: 4fa577c Reason: push, by pascoej Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
Most of the heavy lifting of conditional in create is handled in WebAuthn.
Fixes #225
See also:
https://github.com/w3c/webauthn/pull/1951/files
https://github.com/w3c/webauthn/wiki/Explainer:-Conditional-Registration-Extension
Preview | Diff