Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecurityPolicyViolationEvent's sourceFile seems wrong #267

Closed
annevk opened this issue Nov 17, 2017 · 1 comment
Closed

SecurityPolicyViolationEvent's sourceFile seems wrong #267

annevk opened this issue Nov 17, 2017 · 1 comment
Assignees
@andypaicu

Comments

@annevk
Copy link
Member

annevk commented Nov 17, 2017

sourceFile is a string, but "source file" is null or a URL. Quite a few type mismatches there. I guess you want either the empty string or the URL serialized...

cc @smaug----
@annevk
Copy link
Member Author

annevk commented Nov 17, 2017

This type mismatch concern also applies to "policy" and "originalPolicy".

@andypaicu andypaicu mentioned this issue Nov 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andypaicu andypaicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annevk @andypaicu