Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct set of source expressions in script directives pre-request check #424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bakkot
Copy link

@bakkot bakkot commented Mar 18, 2020

The script directives pre-request check has a part where it talks about the hash-algorithm of an arbitrary source expression. That doesn't make sense. But there's already a variable in scope holding just the hash-source subset of source expressions, which isn't used for anything else except a non-emptiness check. Presumably it should be used instead.

For IPR I would consider this to be non-substantive.


Preview | Diff

Base automatically changed from master to main February 16, 2021 23:21
@w3cbot
Copy link

w3cbot commented Feb 18, 2021

sideshowbarker marked as non substantive for IPR from ash-nazg.

@sideshowbarker
Copy link
Contributor

Rebased (and dropped index.html from the changeset)

@annevk
Copy link
Member

annevk commented Feb 18, 2021

index.html needs to be there though, otherwise the published specification does not get updated.

@sideshowbarker
Copy link
Contributor

index.html needs to be there though, otherwise the published specification does not get updated.

Now that we have the GitHub Actions autodeploy stuff set up, the published specification will automatically get updated when this is merged to the main branch.

@annevk annevk requested a review from antosart February 22, 2021 07:46
Copy link
Member

@antosart antosart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants