Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for an EventTarget before dispatching violation events #549

Merged
merged 2 commits into from Jun 30, 2022
Merged

Check for an EventTarget before dispatching violation events #549

merged 2 commits into from Jun 30, 2022

Conversation

antosart
Copy link
Member

Inside "Report a violation", target can be a WorkletGlobalScope, which is not an EventTarget. In this case, we cannot fire a violation event.

@antosart
Copy link
Member Author

@domenic does this look fine?

domenic
domenic approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit.

index.bs Outdated Show resolved Hide resolved
antosart and others added 2 commits June 30, 2022 06:04
@antosart
Check for an EventTarget before dispatching violation events
6101b0e
@antosart @domenic
nit
723768c 
Co-authored-by: Domenic Denicola <d@domenic.me>
@antosart antosart merged commit 9af8f75 into w3c:main Jun 30, 2022
@antosart antosart deleted the check-event-target branch June 30, 2022 06:33
github-actions bot added a commit that referenced this pull request Jun 30, 2022
@antosart @github-actions
Check for an EventTarget before dispatching violation events (#549)
75b918a 
SHA: 9af8f75
Reason: push, by @antosart

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Oct 4, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antosart @domenic