Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default "Editor's Draft" URL point to MIX2 instead of MIX #34

Merged
merged 4 commits into from Nov 11, 2020

Conversation

carlosjoan91
Copy link
Contributor

@carlosjoan91 carlosjoan91 commented Nov 11, 2020

As discussed in #25 this makes it so the default index.html points to Mixed Content Level 2 (MIX2) instead of Level 1. Level 1 was renamed to level1.html


馃挜 Error: 500 Internal Server Error 馃挜

PR Preview failed to build. (Last tried on Nov 11, 2020, 11:12 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

馃毃 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

馃敆 Related URL

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@carlosjoan91
Copy link
Contributor Author

Anne: Can you please review the change? This PR renames index to level1, and level2 to index (along with some small changes to make bikeshed happy). Thanks!

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though to be fair I mostly looked at index.src.html and trusted the remainder. I found a couple nits that are also fine as follow-ups, up to you.

index.src.html Outdated
Abstract:
This specification describes how a user agent should handle fetching of
content over unencrypted or unauthenticated connections in the context of an
encrypted and authenticated document.
Version History: https://github.com/w3c/webappsec-mixed-content/commits/master/index.src.html
Version History: https://github.com/w3c/webappsec-mixed-content/commits/master/level2.src.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

index.src.html Outdated
<h3 id="category-optionally-blockable">Optionally-blockable Content</h3>
<h3 id="category-upgradeable">Upgradeable Content</h3>

<note>Upgradeable content was previously referred as optionally-blockable in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referred to*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -858,66 +601,22 @@ <h3 id="requirements-user-controls">User Controls</h3>
[[RFC6919]] present such a choice to users without careful consideration and
communication of the risk involved.

A user agent MAY offer users the ability to override its decision to
automatically upgrade <a>upgradeable</a> mixed content on a
particular page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not have this, but I guess I should open an issue for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate if you do. I lean towards having the opt-out ability documented, but I might be biased since Chrome's implementation includes an opt-out. I can be convinced that this is not needed in the spec, but the conversation would be more visible for posterity in an issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if Chrome still includes an opt-out I'm not going to bother.

@carlosjoan91
Copy link
Contributor Author

Thanks for reviewing

@carlosjoan91 carlosjoan91 merged commit ee5efcb into w3c:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants