Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"If the allowlist contains an origin representing self" is unclear #520

Closed
annevk opened this issue Jun 16, 2023 · 2 comments · Fixed by #522
Closed

"If the allowlist contains an origin representing self" is unclear #520

annevk opened this issue Jun 16, 2023 · 2 comments · Fixed by #522
Assignees
@arichiv

Comments

@annevk
Copy link
Member

annevk commented Jun 16, 2023

I think I kinda understand what this means, but this should be more explicit in some way.
@clelland
Copy link
Collaborator

I wasn't sure if the new text was clear enough -- from 4.7, allowlists can have "up to two additional origins (one representing self and one representing src)."

Maybe it would be better to define two additional optional members on allowlist: one for an origin representing self and one for an origin representing src, and then refer to those by name.

@clelland
Copy link
Collaborator

Mentioned on the PR earlier: #516 (comment)

@arichiv FYI

@arichiv arichiv self-assigned this Jun 22, 2023
arichiv added a commit that referenced this issue Jun 26, 2023
@arichiv
Clarify self and src origin naming
3d43bcb 
Since the Allowlist has two optional members we need a
clearer way to refer to them.

closes #520
@arichiv arichiv mentioned this issue Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arichiv arichiv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify self and src origin naming w3c/webappsec-permissions-policy
3 participants
@clelland @arichiv @annevk