Fix referrer calculation to not refer to "API referrer source" #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was discussed in w3c#43.
domenic
force-pushed
the
determine-requests-referrer
branch
from
b5b1f90
to
cd72de6
Compare
| @@ -683,74 +684,53 @@ <h3 id="determine-requests-referrer"> | |||
| associated with it, as detailed in the following steps, which return | |||
| either <code>no referrer</code> or a URL: | |||
|
|
|||
| Note: If Fetch is performing a navigation in response to a link of type | |||
| <code><a>noreferrer</a></code>, then <var>request</var>'s | |||
There was a problem hiding this comment.
Why delete this? I think it's still true/useful.
There was a problem hiding this comment.
Oh, never mind, I just saw you put it below instead.
There was a problem hiding this comment.
Yeah, I thought it would be nice to put it in the switch, because when I was mentally reading that part of the algorithm, I was like, "what about if it's "no-referrer"?" and it took me a while to look up and find this note.
|
Thanks @domenic. Just trying to figure out what's going on with the Travis build... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed in #43. It doesn't necessarily help with #31, but is a good stage-setting for whatever we do there eventually...