Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply subresource integrity to <img> tags #113

Open
mlissner opened this issue Apr 18, 2022 · 0 comments
Open

Apply subresource integrity to <img> tags #113

mlissner opened this issue Apr 18, 2022 · 0 comments

Comments

@mlissner
Copy link

Background...

The subresource integrity spec notes in section 3.4 that:

A future revision of this specification is likely to include integrity support for all possible subresources, i.e., a, audio, embed, iframe, img, link, object, script, source, track, and video elements.

I've poked around and found a couple sort-of-related topics, but they tend to focus on downloads:

Those discussions seem to get tied up (I only skimmed) in questions related to CORS and other things related to downloads that I don't think apply to images, so I thought I'd start a new thread here.

Motivation

At my organization, we do a lot of work to make legal data available. A new service we're launching will host pictures of judges on AWS S3 so that organizations can integrate those judges into their websites and applications. We have a Python project that lets you do something like this:

In[0]: from judge_pics.search import portrait, ImageSizes
In[1]: portrait("ketanji jackson", ImageSizes.SMALL)
Out[1]: 'https://portraits.free.law/v2/128/jackson-ketanji-1970.jpeg'

Then, once you have the link, you pop it into your application and you're set to go.

However, before rolling out this service, I did a short threat analysis: If our clients are hotlinking these judge photos into their websites, how can they be sure we're not serving them porn, or worse. If we get hacked, what could happen to our users of this service?

The best answer that I could come up with is that they could proxy the images through their servers and do a integrity check before serving them from their own domain. Alternatively, there's a JavaScript version of subresource integrity but, well, it's patented (!) and there's a 99% chance it doesn't work as well as the browser does.

Subresource integrity would be the perfect solution to this problem. If we could ship hashes with our Python package, users could easily make a tag like:

<img src="https://portraits.free.law/v2/128/jackson-ketanji-1970.jpeg"
        integrity="sha384-oqVuAfXRKap7fdgcCY5uykM6+R9GqQ8K/uxy9rx7HNQlGYl1kPzQho1wx4JwY8wC"
        crossorigin="anonymous" />

I doubt we're a big target for hackers, but I wish we could give this advice to our users.

Others

Extending this a bit, I could see this being pretty useful for forums and even for image hosting platforms:

  • Random forum could calculate a hash the first time an image is posted by a user and then protect itself from that hotlinked image changing to something lewd or malicious.

  • Google Photos could use integrity hashes to make sure that its own image hosting servers have not been hacked. (I'm assuming they have a distributed architecture with photos in one place and a DB of those photos elsewhere.)

Conclusion

I'm guessing this will go nowhere because there's not a browser vendor backing this (yet?) and there's not a lot of subresource integrity momentum these days, but I think this could be a useful tool and I'd be interested in getting the conversation going if there's interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant