Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid Web IDL syntax #282

Closed
wants to merge 1 commit into from
Closed

Fix invalid Web IDL syntax #282

wants to merge 1 commit into from

Conversation

foolip
Copy link
Member

@foolip foolip commented Jul 3, 2020

With these changes the Web IDL fragments are possible to parse,
but the use of overloading is still in violation of Web IDL:
https://heycam.github.io/webidl/#idl-overloading

With these changes the Web IDL fragments are possible to parse,
but the use of overloading is still in violation of Web IDL:
https://heycam.github.io/webidl/#idl-overloading
@@ -1,8 +1,3 @@
<!--
Before editing this document, please see
https://github.com/w3c/webappsec-trusted-types/blob/master/README.md#spec-changes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't work so I removed it.

@foolip
Copy link
Member Author

foolip commented Jul 3, 2020

I've filed #283 for the overloading problem.

foolip added a commit to foolip/webref that referenced this pull request Jul 3, 2020
foolip added a commit to foolip/webref that referenced this pull request Jul 3, 2020
@foolip
Copy link
Member Author

foolip commented Jul 13, 2020

@mikewest are you the right reviewer for this?

foolip added a commit to foolip/webref that referenced this pull request Jul 13, 2020
foolip added a commit to foolip/webref that referenced this pull request Jul 22, 2020
@koto
Copy link
Member

koto commented Aug 27, 2020

Hey, sorry, I missed that in my inbox.

Thanks for the changes - can you generate the spec file too? npm install will generate the correct pre-commit hooks that do that (npm spec is the actual build target for the spec).

queengooborg pushed a commit to foolip/webref that referenced this pull request Nov 18, 2020
@koto
Copy link
Member

koto commented Nov 25, 2020

Isn't this obsoleted by #283?

@saschanaz
Copy link
Member

saschanaz commented Nov 25, 2020

I think #296 shouldn't have removed the exclude so that crawlers won't bother with them. The suggestion back then probably was to disable IDL index and keep the exclude classes.

This change still totally makes sense, though.

queengooborg pushed a commit to foolip/webref that referenced this pull request Dec 14, 2020
foolip added a commit to foolip/webref that referenced this pull request Jan 21, 2021
foolip added a commit to foolip/webref that referenced this pull request Jan 27, 2021
Base automatically changed from master to main February 16, 2021 23:23
@foolip
Copy link
Member Author

foolip commented Feb 17, 2021

This is obsolete, I'll open another PR.

@foolip foolip closed this Feb 17, 2021
@foolip foolip deleted the patch-1 branch February 17, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants