-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid Web IDL syntax #282
Conversation
With these changes the Web IDL fragments are possible to parse, but the use of overloading is still in violation of Web IDL: https://heycam.github.io/webidl/#idl-overloading
@@ -1,8 +1,3 @@ | |||
<!-- | |||
Before editing this document, please see | |||
https://github.com/w3c/webappsec-trusted-types/blob/master/README.md#spec-changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link doesn't work so I removed it.
I've filed #283 for the overloading problem. |
@mikewest are you the right reviewer for this? |
Hey, sorry, I missed that in my inbox. Thanks for the changes - can you generate the spec file too? |
Isn't this obsoleted by #283? |
I think #296 shouldn't have removed the This change still totally makes sense, though. |
This is obsolete, I'll open another PR. |
With these changes the Web IDL fragments are possible to parse,
but the use of overloading is still in violation of Web IDL:
https://heycam.github.io/webidl/#idl-overloading