Skip to content

Commit

Permalink
Fix type of AuthenticatorAttestationResponseJSON.publicKeyAlgorithm
Browse files Browse the repository at this point in the history
Fixes #2065.

`AuthenticatorAttestationResponseJSON` was added in the L3 drafts, so
we can easily change
`AuthenticatorAttestationResponseJSON.publicKeyAlgorithm` to type
`long` (or `COSEAlgorithmIdentifier`) since L3 isn't formally released
yet. `AuthenticatorAttestationResponseJSON.publicKeyAlgorithm` is also
in output (covariant) position, so changing its type to be more
restrictive is even backwards compatible.
  • Loading branch information
emlun committed May 15, 2024
1 parent 62b069e commit c8eeef5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -1644,7 +1644,7 @@ that are returned to the caller when a new credential is created, or a new asser
// algorithm then the public key must be parsed directly from
// attestationObject or authenticatorData.
Base64URLString publicKey;
required long long publicKeyAlgorithm;
required COSEAlgorithmIdentifier publicKeyAlgorithm;
// This value contains copies of some of the fields above. See
// section “Easily accessing credential data”.
required Base64URLString attestationObject;
Expand Down

0 comments on commit c8eeef5

Please sign in to comment.