Skip to content

Commit

Permalink
Fix indentation of step to invoke authenticatorMakeCredential
Browse files Browse the repository at this point in the history
The current indentation renders this step as a sub-step of "For each credential
descriptor C in pkOptions.excludeCredentials", meaning the operation is to be
invoked once per `excludeCredentials` entry and not at all if
`excludeCredentials` is empty. The indentation appears to have been broken in
commit b44009c (originally
7acc1d5) in PR #1366, caused by a mix of tab
and space characters being replaced with just spaces.
  • Loading branch information
emlun committed Feb 16, 2024
1 parent 99cbcfa commit e239ee5
Showing 1 changed file with 17 additions and 18 deletions.
35 changes: 17 additions & 18 deletions index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -2053,24 +2053,23 @@ a numbered step. If outdented, it (today) is rendered as a bullet in the midst o

1. Otherwise, [=list/Append=] |C| to |excludeCredentialDescriptorList|.

<!-- Note: this next step is actually a step on the same level as the above, but bikeshed wanted it indented this much
in order to render it as a numbered step. If outdented, it (today) is rendered either as a bullet in the midst
of a numbered list or is mis-numbered -->
<li id='CreateCred-InvokeAuthnrMakeCred'>

<!-- @@EDITOR-ANCHOR-01: KEEP THIS LIST SYNC'D WITH OTHER LOCATIONS WITH THIS TAG -->
Invoke the [=authenticatorMakeCredential=] operation on |authenticator| with
|clientDataHash|,
<code>|pkOptions|.{{PublicKeyCredentialCreationOptions/rp}}</code>,
<code>|pkOptions|.{{PublicKeyCredentialCreationOptions/user}}</code>,
|requireResidentKey|,
|userVerification|,
|credTypesAndPubKeyAlgs|,
|excludeCredentialDescriptorList|,
|enterpriseAttestationPossible|,
|attestationFormats|,
and |authenticatorExtensions| as parameters.
</li>
<!-- Note: this next step is actually a step on the same level as the above, but bikeshed wanted it indented this much
in order to render it as a numbered step. If outdented, it (today) is rendered either as a bullet in the midst
of a numbered list or is mis-numbered -->
<li id='CreateCred-InvokeAuthnrMakeCred'>
<!-- @@EDITOR-ANCHOR-01: KEEP THIS LIST SYNC'D WITH OTHER LOCATIONS WITH THIS TAG -->
Invoke the [=authenticatorMakeCredential=] operation on |authenticator| with
|clientDataHash|,
<code>|pkOptions|.{{PublicKeyCredentialCreationOptions/rp}}</code>,
<code>|pkOptions|.{{PublicKeyCredentialCreationOptions/user}}</code>,
|requireResidentKey|,
|userVerification|,
|credTypesAndPubKeyAlgs|,
|excludeCredentialDescriptorList|,
|enterpriseAttestationPossible|,
|attestationFormats|,
and |authenticatorExtensions| as parameters.
</li>

1. [=set/Append=] |authenticator| to |issuedRequests|.

Expand Down

0 comments on commit e239ee5

Please sign in to comment.