-
Notifications
You must be signed in to change notification settings - Fork 165
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clarify that displayName can be the same as name
- Loading branch information
1 parent
a87aa30
commit f09e3d8
Showing
1 changed file
with
6 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f09e3d8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me, though I am curious as to why you changed "The" [=[RP]=] To "A" [=[RP]=], and added "when doing so".
f09e3d8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no good reason, I'll change it back
This was my attempt at something along the lines of, "in most cases you can simply set this to the same value as
user.name
, but if you DO let your users specify the value that gets set foruser.displayName
then let them specify whatever they want." It seems I missed the mark, though - any suggestions on how to better capture this sentiment here?f09e3d8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't worry about being so verbose. Personally I would have left it as it was:
Honestly, it's splitting hairs at this point.