Skip to content

Commit

Permalink
Clarify that displayName can be the same as name
Browse files Browse the repository at this point in the history
  • Loading branch information
@MasterKale
MasterKale committed Aug 1, 2023
1 parent a87aa30 commit f09e3d8
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions index.bs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3257,9 +3257,12 @@ credential.
:: A [=human palatability|human-palatable=] name for the [=user account=], intended only for display.
[=Clients=] may display this value to help users differentiate between multiple sub-accounts for a
given [=user account=] for situations in which every credential uses the same value for
{{PublicKeyCredentialEntity/name}}. Examples of suitable values for this identifier include,
"Alex Müller" or "田中倫". The [=[RP]=] SHOULD let the user choose this, and SHOULD NOT restrict
the choice more than necessary.
{{PublicKeyCredentialEntity/name}}. When such differentiation is not required, this value
MAY be set to the same value as {{PublicKeyCredentialEntity/name}}. Examples of suitable values for this identifier include,
"Alex Müller" or "田中倫".

A [=[RP]=] MAY let the user specify this value, and SHOULD NOT restrict the choice
more than necessary when doing so.

- [=[RPS]=] SHOULD perform enforcement, as prescribed in Section 2.3 of
[[!RFC8266]] for the Nickname Profile of the PRECIS FreeformClass [[!RFC8264]],
Expand Down

3 comments on commit f09e3d8

@sbweeden
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, though I am curious as to why you changed "The" [=[RP]=] To "A" [=[RP]=], and added "when doing so".

@MasterKale
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...though I am curious as to why you changed "The" [=[RP]=] To "A" [=[RP]=]

Ah, no good reason, I'll change it back

...and added "when doing so".

This was my attempt at something along the lines of, "in most cases you can simply set this to the same value as user.name, but if you DO let your users specify the value that gets set for user.displayName then let them specify whatever they want." It seems I missed the mark, though - any suggestions on how to better capture this sentiment here?

@sbweeden
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't worry about being so verbose. Personally I would have left it as it was:

The [=[RP]=] SHOULD let the user choose this, and SHOULD NOT restrict the choice more than necessary.

Honestly, it's splitting hairs at this point.

Please sign in to comment.