Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad instructions in Android SafetyNet attestation validation steps #1018

Closed
sbweeden opened this issue Jul 28, 2018 · 3 comments
Closed

Bad instructions in Android SafetyNet attestation validation steps #1018

sbweeden opened this issue Jul 28, 2018 · 3 comments
Assignees
Milestone

Comments

@sbweeden
Copy link
Contributor

In section 8.5 (https://www.w3.org/TR/webauthn/#android-safetynet-attestation) there are validation instructions for the Android SafetyNet Attestation Statement Format.

One of these states:

"Verify that the nonce in the response is identical to the concatenation of authenticatorData and clientDataHash."

This is actually wrong. The nonce actually seems to be:
b64encode(sha256(authenticatorData + clientDataHash));

Please confirm with the Google team first, but that seems to be the needed check to me.

@herrjemand
Copy link
Contributor

https://w3c.github.io/webauthn/#android-safetynet-attestation

Verify that the nonce in the response is identical to the SHA-256 hash of the concatenation of authenticatorData and clientDataHash.

@sbweeden In future please submit issues against the Editorial Draft that located here: https://w3c.github.io/webauthn/

Proposing closing this with "non-issue"

@sbweeden
Copy link
Contributor Author

I'll concede fair point on the location of the document to review. I won't quite concede on the "non-issue" statement.

The output of a sha256 operation is a byte array. The nonce in the jws payload of the response is a base64 encoded representation of this.

@samuelweiler samuelweiler added this to the PropRec milestone Aug 1, 2018
arnar added a commit to arnar/webauthn that referenced this issue Aug 1, 2018
@arnar
Copy link
Contributor

arnar commented Aug 1, 2018

We can indeed clarify that the JWS nonce field is base64 encoded. See #1021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants