Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the "authentication" attribute on Navigator be [SameObject]? #249

Closed
bzbarsky opened this issue Nov 4, 2016 · 7 comments
Closed

Comments

@bzbarsky
Copy link

bzbarsky commented Nov 4, 2016

And in general, should it have some sort of processing model defined? Right now nothing defines what this attribute actually returns. Does the returned value depend on the "this" value, or on the Realm of the attribute getter, or something else?

Presumably this should be [SameObject] hence and the return value should depend only on the "this" value, and should be associated to the same global as the "this" value.

@equalsJeffH equalsJeffH added this to the WD-04 milestone Nov 6, 2016
@equalsJeffH
Copy link
Contributor

It seems to me that [SameObject] is appropriate given the description at https://heycam.github.io/webidl/#SameObject - thoughts?

@selfissued
Copy link
Contributor

Until it is specified what this returns, it can be a source of interop issues. We need to specify this for the Implementer's Draft.

@selfissued
Copy link
Contributor

From discussion on the call, it sounds like we should do this.

@equalsJeffH
Copy link
Contributor

@bzbarsky -- might you have a ptr to example text that addresses: "the return value should depend only on the "this" value, and should be associated to the same global as the "this" value." ?

@bzbarsky
Copy link
Author

bzbarsky commented Apr 5, 2017

Addresses in what sense?

The obvious way to do that is to have it stored in a slot of "this", create when needed, when creating use the relevant global of "this".

@mikewest
Copy link
Member

I think this is obviated by #384, which moves things to navigator.credentials, which is already [SameObject]: https://w3c.github.io/webappsec-credential-management/#framework-credential-management

@equalsJeffH
Copy link
Contributor

@mikewest

I think this is obviated by #384

agreed, will close with PR #384 merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants