Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"authentication" attribute on Navigator should be [SecureContext] #250

Closed
bzbarsky opened this issue Nov 4, 2016 · 6 comments
Closed

"authentication" attribute on Navigator should be [SecureContext] #250

bzbarsky opened this issue Nov 4, 2016 · 6 comments

Comments

@bzbarsky
Copy link

bzbarsky commented Nov 4, 2016

The WebAuthentication interface is, but the "authentication" attribute is not. That seems a bit odd. If this is purposeful, it's worth a note explaining why.

@equalsJeffH equalsJeffH added this to the WD-04 milestone Nov 6, 2016
@equalsJeffH
Copy link
Contributor

it is not purposeful -- is not clear (to me) from https://heycam.github.io/webidl and https://www.w3.org/TR/secure-contexts/ that we need to add the [SecureContext] extended attr to Navigator.authentication. we can certainly add it.

@bzbarsky
Copy link
Author

bzbarsky commented Nov 7, 2016

It depends on your desired behavior. What should navigator.authentication return on a page loaded from "http://example.com"?

@selfissued
Copy link
Contributor

Since this affects behavior of implementations, we should decide this and address it for the Implementer's Draft.

@equalsJeffH
Copy link
Contributor

It would seem this issue will go away if PR #384 "integration of webauthn and credman" is merged?

@mikewest
Copy link
Member

I also think this is obviated by #384, which moves things to navigator.credentials, which is already [SecureContext]: https://w3c.github.io/webappsec-credential-management/#framework-credential-management

@equalsJeffH
Copy link
Contributor

fixed by PR #384, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants