Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excludeList/allowList can be defaulted to a zero-length sequence in IDL instead of prose #268

Closed
bzbarsky opened this issue Nov 4, 2016 · 3 comments · Fixed by #495
Closed
Assignees
Milestone

Comments

@bzbarsky
Copy link

bzbarsky commented Nov 4, 2016

Instead of having https://w3c.github.io/webauthn/#dom-webauthentication-makecredential step 6 say

If excludeList is undefined, set it to the empty list.

it would probably be better to have the IDL for the ScopedCredentialOptions dictionary say:

sequence<ScopedCredentialDescriptor>  excludeList = [];

so you don't have to worry about this situation in prose at all.

@bzbarsky bzbarsky changed the title excludeList can be defaulted to a zero-length sequence in IDL instead of prose excludeList/allowList can be defaulted to a zero-length sequence in IDL instead of prose Nov 4, 2016
@bzbarsky
Copy link
Author

bzbarsky commented Nov 4, 2016

This applies to the allowList member of AssertionOptions too.

@equalsJeffH equalsJeffH added this to the WD-04 milestone Nov 7, 2016
@equalsJeffH equalsJeffH self-assigned this Jun 26, 2017
@equalsJeffH equalsJeffH modified the milestones: WD-06, WD-04 Jun 26, 2017
@equalsJeffH
Copy link
Contributor

reopening because: excludeList aka excludeCredentials (along with allowList aka allowCredentials) was defined as defaulting to a zero-length sequence in commit 8963f21, but the = [] was dropped from excludeCredentials in some recent commit. We need to fix it.

@equalsJeffH
Copy link
Contributor

I queued the fix for this in PR #495

selfissued pushed a commit that referenced this issue Jul 29, 2017
…akeCredential (#502)

* explicitly level 1, fixes #475

* improve allowCredentials and transports handling in #getAssertion, fixes #480

* Update index.bs

* add requireResidentKey param to authenticatorMC

* added ... identified by rpId for clarification

* grammar fixup

* Update index.bs

* fix linking error

* add back ' = []' on excludeCredentials, fixes #268

* add links to scribe/bot instructions

* Fix typo.

* Fix typo

* Renamed MakeCredentialOptions to MakePublicKeyCredentialOptions and parameters to pubKeyCredParams

* Have parameter orders match those in the Authenticator Operations section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants