-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should WebAuthnAttestation attributes have constructors? #313
Comments
you are suggesting something like:
yes? A question is whether to allow for any, some, or all attr values to be passed-in via the constructor. It seems at least "format" would be a candidate (as illustrated above). thoughts? Also, if we are adding
|
per https://www.w3.org/2017/01/04-webauthn-minutes.html @vijaybh (aka vgb, Vijay) said: "[i'm working on attestation and this may be related" -- thus noting the overall revamp attestation issue #244 here |
This CL adds the WebAuthn bindings and interface to support WebAuthentication.makeCredential and WebAuthentication.getAssertion. The draft spec is here: https://w3c.github.io/webauthn/ The interface is likely to change as the spec matures. We're tracking the comments and suggestions from this review via issues opened with the working group: w3c/webauthn#310 w3c/webauthn#311 w3c/webauthn#312 w3c/webauthn#313 This patch also proactively implements the change to WebAuthnAttestation suggested here: w3c/webauthn#244 BUG=664630 Review-Url: https://codereview.chromium.org/2533863002 Cr-Commit-Position: refs/heads/master@{#445239}
The WebAuthnAttestation interface was removed by #321. |
If so, probably should be tacked in conjunction with or after issue #244 simplifies attestation.
The text was updated successfully, but these errors were encountered: