Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attestation type identifiers and their use is only implicitly defined #746

Closed
equalsJeffH opened this issue Jan 12, 2018 · 5 comments · Fixed by #780
Closed

attestation type identifiers and their use is only implicitly defined #746

equalsJeffH opened this issue Jan 12, 2018 · 5 comments · Fixed by #780

Comments

@equalsJeffH
Copy link
Contributor

equalsJeffH commented Jan 12, 2018

all defined attestation formats contain, in their verification procedure, a statement of this form:

If successful, return attestation type <foo> and <bar> attestation trust path

However, attestation type identifiers are only implicitly defined is the above-cited statements. [note also: the term "attestation type identifier" is not used or defined.]

By combing thru all such above-cited statements, it appears the present set of attestation type identifiers is:

Basic
ECDAA
Self
Privacy CA

The "ECDAA" one is sort of defined in S 6.3.3. Attestation Types.

We ought to formally define all of the attestation type identifiers and appropriately auto-link them to their <dfn>s. Note that PR #741 may add a fifth attestation type of "None".

Also, matching of attestation type identifiers is undefined (i.e. is it case-sensitive or not?), nor their syntax (e.g., is interstitial whitespace allowed? What is the charset allowed?), are defined.

@emlun
Copy link
Member

emlun commented Jan 15, 2018

The verification procedures are run wholly within the RP, and the RP can determine the attestation type from the contents of the attestation, so any representation of the attestation type would be used only internally by the RP. Thus there's no need for strictly defined identifiers (because the RP would be both the creator and the consumer of the "returned attestation type") or matching rules for the attestation types.

It seems like a good idea to define and link the terms within the document, but I think that could be regarded an editorial issue.

@selfissued
Copy link
Contributor

Where in the spec where you thinking that the list of types should reside, @equalsJeffH ? Do you agree that this is a strictly editorial indexing exercise?

@equalsJeffH
Copy link
Contributor Author

@selfissued

Do you agree that this is a strictly editorial indexing exercise?

yes.

@selfissued
Copy link
Contributor

Can you create a PR for this, @equalsJeffH ? Then I'll review.

@equalsJeffH
Copy link
Contributor Author

see PR #780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment