Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 746: uniformly define attestation type short identifiers #780

Merged
merged 3 commits into from Feb 7, 2018

Conversation

equalsJeffH
Copy link
Contributor

@equalsJeffH equalsJeffH commented Feb 6, 2018

fixes #746 "attestation type identifiers and their use is only implicitly defined"


Preview | Diff

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nadalin
Copy link
Contributor

nadalin commented Feb 7, 2018

@equalsJeffH Can you merge ?

@equalsJeffH equalsJeffH merged commit d56d1e7 into master Feb 7, 2018
WebAuthnBot pushed a commit that referenced this pull request Feb 7, 2018
@emlun emlun deleted the jeffh-fix-746-attstn-type-ids branch June 12, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attestation type identifiers and their use is only implicitly defined
4 participants