Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar error in Sec 13.1 #866

Closed
sparticvs opened this issue Apr 11, 2018 · 2 comments · Fixed by #977
Closed

Grammar error in Sec 13.1 #866

sparticvs opened this issue Apr 11, 2018 · 2 comments · Fixed by #977
Assignees
@equalsJeffH
Labels
stat:pr-open type:editorial
Milestone
PropRec

Comments

@sparticvs
Copy link

Therefore, both challenge's and challenge's value MUST be...

That reads weird. I think it might be clearer to the reader worded as such

Therefore, the value for challenge options in PublicKeyCredentialCreationOptions and PublicKeyCredentialRequestOptions [dictionaries] MUST be...
@equalsJeffH equalsJeffH self-assigned this Apr 11, 2018
@nadalin nadalin added this to the PR milestone Apr 11, 2018
@selfissued
Copy link
Contributor

Who is creating the PR to fix this?

@equalsJeffH
Copy link
Contributor

it is assigned to me so I am :)

I intend to do a batch editorial PR which fixes a bunch of the editorial issues, both open and those i discover every time I read thru the spec in detail. see also issue #932 which is an example of such discovery (tho more serious imv so i did a specific PR to deal with it #933)....

@equalsJeffH equalsJeffH mentioned this issue Jun 28, 2018
Merged
equalsJeffH added a commit that referenced this issue Jul 6, 2018
@equalsJeffH
fix #866: clarify sentence wrt challenges (#977)
a96110e 
* fix 866

* add link to CollectedClientData/challenge, thx emlun!
WebAuthnBot pushed a commit that referenced this issue Jul 6, 2018
Built by Travis-CI: a96110e fix #866: clarify sentence wrt challenges (…
87d5ec3 
…#977)
WebAuthnBot pushed a commit that referenced this issue Jul 6, 2018
Built by Travis-CI: a96110e fix #866: clarify sentence wrt challenges (…
cc7affb 
…#977)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@equalsJeffH equalsJeffH

Labels
stat:pr-open type:editorial
Projects
None yet
Milestone
PropRec
Development

Successfully merging a pull request may close this issue.

fix #866: clarify sentence wrt challenges w3c/webauthn
5 participants
@equalsJeffH @sparticvs @emlun @selfissued @nadalin