Make implementation-specificness of attestn.verif. return values more explicit #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equalsJeffH
approved these changes
Sep 18, 2018
index.bs
Outdated
| @@ -3944,10 +3949,12 @@ even if the SafetyNet API is also present. | |||
| contained fields. | |||
| - Verify that |response| is a valid SafetyNet response of version |ver|. | |||
| - Verify that the nonce in the |response| is identical to the Base64url encoding of the SHA-256 hash of the concatenation of |authenticatorData| and |clientDataHash|. | |||
| - Verify that the attestation certificate is issued to the hostname "attest.android.com" (see | |||
| - Let |attestationCert| be the attestation certificate. | |||
| - Verify that |attestatioCert| is issued to the hostname "attest.android.com" (see | |||
index.bs
Outdated
| @@ -3944,10 +3949,12 @@ even if the SafetyNet API is also present. | |||
| contained fields. | |||
| - Verify that |response| is a valid SafetyNet response of version |ver|. | |||
| - Verify that the nonce in the |response| is identical to the Base64url encoding of the SHA-256 hash of the concatenation of |authenticatorData| and |clientDataHash|. | |||
| - Verify that the attestation certificate is issued to the hostname "attest.android.com" (see | |||
| - Let |attestationCert| be the attestation certificate. | |||
There was a problem hiding this comment.
[=attestation certificate=] ?
index.bs
Outdated
| [SafetyNet online documentation](https://developer.android.com/training/safetynet/index.html#compat-check-response)). | ||
| - Verify that the `ctsProfileMatch` attribute in the payload of |response| is [TRUE]. | ||
| - If successful, return attestation type [=Basic=] with the [=attestation trust path=] set to the above attestation certificate. | ||
| - If successful, return implementation-specific values representing attestation type [=Basic=] and [=attestation trust path=] |
There was a problem hiding this comment.
[=attestation type=] ?
emlun
added
the
process:meta-pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1054 (comment)
Preview | Diff