Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add None attestation case to RP ops registration step 16 #1145

Merged
merged 1 commit into from Feb 13, 2019
Merged

Add None attestation case to RP ops registration step 16 #1145

merged 1 commit into from Feb 13, 2019

Conversation

emlun
Copy link
Member

@emlun emlun commented Jan 18, 2019 •
edited by pr-preview bot

Fixes #1136.

Preview | Diff

@emlun emlun self-assigned this Jan 18, 2019
@nadalin nadalin requested a review from akshayku January 23, 2019 18:24
@agl
Copy link
Contributor

agl commented Jan 23, 2019

LGTM

equalsJeffH
equalsJeffH approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @emlun!

@herrjemand
Copy link
Contributor

LGTM

@nadalin nadalin added this to the L2-WD-00 milestone Jan 23, 2019
selfissued
selfissued approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

agl
agl approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@agl agl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (I said that above, but doing so again in a review so that GitHub recognises it.)

@nadalin
Copy link
Contributor

nadalin commented Feb 13, 2019

@emlun Please merge

@emlun emlun merged commit 1909b5f into master Feb 13, 2019
@emlun emlun deleted the issue-1136-none-attestation-policy branch February 13, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agl agl agl approved these changes

@equalsJeffH equalsJeffH equalsJeffH approved these changes

@selfissued selfissued selfissued approved these changes

@akshayku akshayku akshayku approved these changes

Assignees

@emlun emlun

Labels
subtype:attestation subtype:rp-ops type:technical
Projects
None yet
Milestone
L2-WD-01
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@emlun @agl @herrjemand @nadalin @equalsJeffH @selfissued @akshayku