Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created linkable definition for WebAuthn Extensions and linked to it … #1193

Merged
merged 2 commits into from Apr 17, 2019
Merged

Created linkable definition for WebAuthn Extensions and linked to it … #1193

merged 2 commits into from Apr 17, 2019

Conversation

futureimperfect
Copy link
Contributor

@futureimperfect futureimperfect commented Mar 25, 2019 •
edited by pr-preview bot

…throughout the spec. Fixes #1180.

Preview | Diff

@nadalin nadalin requested review from emlun and akshayku April 3, 2019 07:10
@nadalin nadalin added this to the L2-WD-01 milestone Apr 3, 2019
emlun
emlun reviewed Apr 3, 2019
View reviewed changes
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 more occurrences of "WebAuthn Extensions" at lines 2216, 2226 and 2235. I think we can also remove the ", as defined in ..." subordinate clauses if we link the "WebAuthn Extensions" terms there.

emlun
emlun approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@equalsJeffH equalsJeffH self-requested a review April 17, 2019 17:41
equalsJeffH
equalsJeffH approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks much @futureimperfect !

@nadalin
Copy link
Contributor

nadalin commented Apr 17, 2019

@futureimperfect Please merge

@emlun emlun merged commit 5d11e62 into w3c:master Apr 17, 2019
WebAuthnBot pushed a commit that referenced this pull request Apr 17, 2019
Built by Travis-CI: 5d11e62 Merge pull request #1193 from futureimper…
42530c8 
…fect/create-linkable-def-for-webauthn-exts
WebAuthnBot pushed a commit that referenced this pull request Apr 17, 2019
Built by Travis-CI: 5d11e62 Merge pull request #1193 from futureimper…
25edbab 
…fect/create-linkable-def-for-webauthn-exts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agl agl agl approved these changes

@equalsJeffH equalsJeffH equalsJeffH approved these changes

@emlun emlun emlun approved these changes

@selfissued selfissued selfissued approved these changes

@akshayku akshayku akshayku approved these changes

Assignees

@futureimperfect futureimperfect

Labels
type:editorial
Projects
None yet
Milestone
L2-WD-01
Development

Successfully merging this pull request may close these issues.

Create linkable definition for "WebAuthn Extension(s)"
7 participants
@futureimperfect @nadalin @agl @equalsJeffH @emlun @selfissued @akshayku